https://bugzilla.redhat.com/show_bug.cgi?id=1428693 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@xxxxxxxxx --- Comment #6 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Very Very Preliminary review: 1) Package failed to build in mock. It failed as spec is using autoreconf but that binary is not available in build environment. Fix this as BuildRequires: autoconf 2) SPEC file must not contain version number. Change netpgp-3.99.17.spec to netpgp.spec 3) Packager and Vendor tags are not used in Fedora packaging. 4) Source0: should provide direct downloadable URL I suggest check with upstream if they can release any tarball otherwise we need to document the steps on how you created source archive as comments just before Source0: line. 5) Any BuildRequires or Requires for any package should not restrict versions. In this package I see Requires: netpgpverify = %{version} which should be Requires: netpgpverify 6) We don't need these %defines. Remove them. %define _unpackaged_files_terminate_build 0 %define _prefix /usr We already define _prefix to /usr. See /usr/lib/rpm/macros file. 7) For %prep section, Fedora packaging guidelines now recommends use of %autosetup 8) for %build we have those macros already defined in /usr/lib/rpm/macros no need to specify them. I think its better if upstream will provide some release where configure will already be available. Then you will not need to use autoreconf. Any C library providing package generally have these lines in spec %configure --disable-static make %{?_smp_mflags} 9) for %install any general library providing package should have lines make install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' 9) We no longer need every %files section to write %defattr(-,root,root) and then for every listed files to start with %attr(0755,root,root) 10) for library package we only need %post -p /sbin/ldconfig %postun -p /sbin/ldconfig and not other %pre, %preun. See more on scriptlet here https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries 11) We no loner need to write %clean Hope this will at least help you to start moving this package updates. Please remember whenever someone suggests any changes you need to increase release tag by 1 and add appropriate changelog entry e.g. "Review suggestions fixes". This is the way package submitter need to provide updates. Also every time you need to specify both the links that is Spec URL and SRPM URL. If not provided reviewer cannot use fedora-review tool to review your package and thus you will not get any inputs here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx