[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #6 from Olivier Lemasle <o.lemasle@xxxxxxxxx> ---
Hello Athos,

Thank you for your review.

- Regarding the directory ownership, I think I understand better now; I'll fix
it.

- You're right, the examples directory contains code that is not part of the
library (is not meant to be used in the code), so I'll add it to the %doc.

- Regarding the "cmd/ace" package and its main.go program, I'm not sure... It
would be interesting to include it in the main package as a binary (not in the
-devel subpackage), but do we need it? Furthermore, it depends on
https://github.com/yosssi/gohtml (cf. [1]) which is currently not packaged in
Fedora. What do you think is the best?

[1] https://github.com/yosssi/ace/blob/v0.0.5/cmd/ace/main.go#L11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]