https://bugzilla.redhat.com/show_bug.cgi?id=1428202 Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dwrobel@xxxxxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |dwrobel@xxxxxxxxxxxxxxxxxx --- Comment #2 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- Please find some initial comments: %doc COPYING COPYING should go to %license, please also remove the redundant space character in front of %doc %doc README* It's minor, but it causes that both README and README.md are packaged, although both are identical: $ sha256sum README README.md 6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6 README 6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6 README.md Maybe upstream can simply remove one of it? %dir %{_datadir}/%{name}/translations %dir %{_datadir}/%{name} Please consider reverting the order of them, will look more natural. -rwxr-xr-x 1 root root 332 Mar 8 16:24 /usr/share/applications/sirikali.desktop Destkop file seems to have superfluous executable attribute. Based on the project's homepage[1]: cryfs binary application is required to be installed for SiriKali to gain support for cryfs volumes. gocryptfs binary application is required to be installed for SiriKali to gain support for gocryptfs volumes. encfs binary application is required to be installed for SiriKali to gain support for encfs volumes. securefs binary application is required to be installed for SiriKali to gain support for securefs volumes. But the package itself doesn't list any of them as a run-time dependency. BTW, we don't seem to have cryfs: $ dnf provides '*cryfs' Last metadata expiration check: 2:21:08 ago on Wed Mar 8 15:59:56 2017. Error: No Matches found [1] https://mhogomchungu.github.io/sirikali/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx