Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alliance - Alliance VLSI CAD Sytem https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248649 ------- Additional Comments From kwizart@xxxxxxxxx 2007-07-24 12:23 EST ------- Review of version - release : 5.0-3.20070718snap * From Previous comments: - multilibs, As there is no more -devel package, the multilibs problems on repository is solved. This mean there is no headers to write plugins for alliance ? Then OK. - 5 Ok for not using desktop-file-utils. But on my Gnome environnement, the menues are showed in Edutainment which is not a right name in my view (mostly because it is not translated) Also X-Desktop-File-Install-Version=0.10 in sources desktop files is wrong. This field is added at install time..Be carefull that desktop-file-install in F8 rawhide is no more permissive with theses littles errors. (not tested yet...) - 7 / 9 / 16 : OK - Still i don't understand why you used macro for name of patches. That might be better to have them in full name (as the name will not change) * New comments: (now it builds in mock on x86_64) (rpmlint on rpm packages ) - Names are too generic. For headers in %{_includedir}/*.h and libraries in %{_libdir}/*.so, maybe you can at least uses a subdirectory with them (and put a path for in /etc/ld.so.conf.d ) When trying to install it: ----------- le fichier /usr/include/btr.h de l'installation de alliance-5.0-3.20070718snap.fc6 entre en conflit avec le fichier du paquetage mx-2.0.6-2.2.2 le fichier /usr/share/man/man3/log.3.gz de l'installation de alliance-5.0-3.20070718snap.fc6 entre en conflit avec le fichier du paquetage man-pages-2.39-7.fc6 ---------- - E: alliance non-executable-script /etc/alliance/attila.conf 0644 See why this is considered as script (may be safe to ignore... Also, maybe not all files in /etc/%{name} will need %config(no replace) This can be better to have only %{config} for some of them. For example if they are changing between release and need to be updated with no user choice... For files that depend on users choice , the better way could be to have files to be sourced in a sub-directory... (maybe not relevant, in this case...) - W: alliance non-conffile-in-etc /etc/alliance/alc_env.csh Not sure it is the right place for it...?! why this have changed from profiles.d ? (rpmlint on installed file : rpmlint alliance ) - Untested - (package cannot be installed becaue mx is in use) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review