[Bug 1403417] Review Request: gsequencer - audio processing engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #32 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> You are right it doesn't work anymore. However I have tested it and it was
> working for that package.

Probably prior to deleting the RPATH from the program?


> The library is there and it is in a private location.

And that's why runtime linker cannot find it.


> I think you don't want that?

Fedora? You may have misread something in the guidelines. Maybe the following
section? https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

Let's not mispackage gsequencer. Hiding the lib in a private path serves no
purpose, if it breaks the program. Quite obviously, the program is to be
packaged in a way that it works. If you find something in the guidelines that
seems to conflict with how you want to package the software, discuss this
during review or on packaging@ list. It's even possible to contact the
packaging committee directly if you think something in the guidelines is wrong.


> I have read once that on RPM based systems no libraries are private.

Sounds strange. Certainly there are lots of shared libs with no public API (and
no -devel package) installed within runtime linker's search path.


> Note the private library contains an unstable API that might change.

No issue at all.


> I could provide a patch to make libgsequencer.so* resident in
> default linker location.

That would be the correct solution. Or an RPATH. And you could delete
libgsequencer.so, because the program is linked with libgsequencer.so.1 and
looks for that SONAME anyway.

https://fedoraproject.org/wiki/Packaging:Guidelines#Rpath_for_Internal_Libraries
https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath


> But then you might want to provide the
> header files of libgsequencer, too.

No. That's a false conclusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]