[Bug 1426954] Review Request: golang-github-chaseadamsio-goorgeous - A Go Org to HTML Parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1426954

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Package looks good (full fedora-review output in the attachment).
Just two minor remarks:

- You *should* re-phrase the %summary to comply with the
"summary-not-capitalized" rpmlint warning, for example: "ORG to HTML parser
written in Go" (or something like that). Additionally, repeating the
project/package name in the summary is frowned upon.

- You *could* remove empty %if-%endif blocks (or ones that just contain
comments) to clean up the .spec file a bit. But if you want to leave them in,
that's fine (and it makes it a bit easier to fill in new dependencies if the
package ever grows some in the future).


Once you have decided on a "fully compliant" Summary tag, I will approve the
package (you don't have to bump the spec file and rebuild the srpm, fixing it
upon git import is enough).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]