[Bug 1429970] Review Request: libjaylink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1429970



--- Comment #2 from Alex G. <mr.nuke.me@xxxxxxxxx> ---
Requested changes summary
=========================

[!]: Requires correct, justified where necessary.

> BuildRequires:  pkgconfig, libusbx-devel
Should be expressed as pkgconfig(libusb)
https://fedoraproject.org/wiki/Packaging:PkgConfigBuildRequires

> BuildRequires:  gcc
Part of the standard buildroot. No need to list explicitly.

> BuildRequires:  libtool, automake, autoconf
auto*make is not run during build, so these are not requirements.

Once you are done, the line should read: BuildRequires:  pkgconfig(libusb)


[!] contrib/99-libjaylink.rules not packaged.

Should package the udev rules files for this to be useful for non-root users.
Will need to modify it a bit to match Fedora:
sed 's/MODE="664", GROUP="plugdev"/TAG+="uaccess"/'
before installing to /lib/udev/rules.d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]