https://bugzilla.redhat.com/show_bug.cgi?id=1413474 VincentS <vincent@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vincent@xxxxxxxxxxxxxxxxxx --- Comment #6 from VincentS <vincent@xxxxxxxxxxxxxxxxxx> --- Hello, I'm not yet a packager, so this is an unofficial review. REVIEW: + OK - NA X ISSUE + Package meets naming and packaging guidelines. + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. X Sources match upstream sha256sum: $ sha256sum pycdlib-1.1.0.tar.gz rpmbuild/SOURCES/pycdlib-1.1.0.tar.gz ae0d2aa92dbb40849666f4bcdd9b2c89f1c4e38cdd42bcb9a89a9e9aab8f14f6 pycdlib-1.1.0.tar.gz bd32606ded8d7bdd339d1024fd8a724342a1c0eb0d1c10625e144a467f9096a5 rpmbuild/SOURCES/pycdlib-1.1.0.tar.gz - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + Rpmlint output: $ rpmlint fedora_review/pycdlib/python-pycdlib.spec fedora_review/pycdlib/python-pycdlib-1.1.0-1.fc25.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/pycdlib-tools-1.1.0-1.fc27.noarch.rpm python-pycdlib.src: W: file-size-mismatch pycdlib-1.1.0.tar.gz = 127613, https://github.com/clalancette/pycdlib/archive/v1.1.0/pycdlib-1.1.0.tar.gz = 136340 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + final provides and requires are sane. SHOULD Items: + Should build in mock. + Should build on all supported archs + Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag + Should package latest version Issues: 1. Sources doesn't match with upstream. You should verify your sources and rebuild the package with upstream sources. By the way, I think it could be great to plan a porting to Python3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx