https://bugzilla.redhat.com/show_bug.cgi?id=1339227 VincentS <vincent@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vincent@xxxxxxxxxxxxxxxxxx --- Comment #1 from VincentS <vincent@xxxxxxxxxxxxxxxxxx> --- Hello, I'm not yet a packager, so this is an unofficial review. Package Review ============== REVIEW: + OK - NA X ISSUE + Package meets naming and packaging guidelines. + Spec file matches base package name. + Spec has consistant macro usage. + Meets Packaging Guidelines. + License + License field in spec matches + License file included in package + Spec in American English + Spec is legible. X Sources match upstream sha256sum: $ sha256sum ~/fileobj-0.7.34.tar.gz ~/rpmbuild/SOURCES/fileobj-0.7.34.tar.gz 6ff88b1eb6fc7dc448723951d51f21f8a52bd0a21a977bc8e1ddfa737c8b2a91 ~/fileobj-0.7.34.tar.gz 91818f82eb278c27412225c09ad7732c1962589f11652b19c781fbb5f95065e6 ~/rpmbuild/SOURCES/fileobj-0.7.34.tar.gz ^^ I think you may update to the last version: v0.7.46 - Package needs ExcludeArch + BuildRequires correct - Spec handles locales/find_lang - Package is relocatable and has a reason to be. + Package has %defattr and permissions on files is good. + Package is code or permissible content. + Doc subpackage needed/used. + Packages %doc files don't affect runtime. - Headers/static libs in -devel subpackage. - Spec has needed ldconfig in post and postun - .pc files in -devel subpackage/requires pkgconfig - .so files in -devel subpackage. - -devel package Requires: %{name} = %{version}-%{release} - .la files are removed. - Package is a GUI app and has a .desktop file + Package compiles and builds on at least one arch. + Package has no duplicate files in %files. + Package doesn't own any directories other packages own. + Package owns all the directories it creates. + Rpmlint output: $ rpmlint fedora_review/fileobj/fileobj.spec /var/lib/mock/fedora-rawhide-x86_64/result/fileobj-0.7.34-1.fc27.src.rpm /var/lib/mock/fedora-rawhide-x86_64/result/fileobj-0.7.34-1.fc27.noarch.rpm fedora_review/fileobj/fileobj.spec: W: invalid-url Source0: https://downloads.sourceforge.net/project/fileobj/fileobj-0.7.34.tar.gz HTTP Error 404: Not Found fileobj.src: W: invalid-url Source0: https://downloads.sourceforge.net/project/fileobj/fileobj-0.7.34.tar.gz HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 0 errors, 2 warnings. ^^ Sources aren't available on its link. I think you may use the GitHub release link. + final provides and requires are sane. SHOULD Items: + Should build in mock. + Should build on all supported archs - Should function as described. - Should have sane scriptlets. - Should have subpackages require base package with fully versioned depend. + Should have dist tag - Should package latest version - check for outstanding bugs on package. (For core merge reviews) Issues: 1. Sources doesn't match with upstream. 2. I think you should update to the last version available. 3. It will be better if you find another sources link. You should verify your sources and rebuild the package with upstream sources. If you would like to be sponsored, I advise you to do informal review on other review requests, you need to show you're interested in packaging and you know packaging and reviewing guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
