https://bugzilla.redhat.com/show_bug.cgi?id=1428035 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@xxxxxxxx | |m) --- Comment #18 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- Spec: https://sgallagh.fedorapeople.org/packagereview/modular-release/fedora-modular-release.spec SRPM: https://sgallagh.fedorapeople.org/packagereview/modular-release/fedora-modular-release-26-0.7.fc26.src.rpm (In reply to Neal Gompa from comment #17) > @Stephen: Thanks for fixing URL for spec. > > Couple of remaining things I noticed: > > * URL is invalid. I think you mean > https://github.com/sgallagher/modularity-release ? Or do you intend to have > a Pagure repo for this? > Once it gets created in dist-git, we'll probably use dist-git as the official upstream source for it, since there's no benefit at all to having a separate upstream. For now, I've just fixed the URL (and renamed my github repo to match the new name). > * NAME in os-release should be "Fedora Modular" rather than "Fedora". It > should also be a quoted string (since it will have a space). Yes, thanks. I missed that. Good eye :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx