https://bugzilla.redhat.com/show_bug.cgi?id=1428035 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo? --- Comment #14 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- Spec: https://sgallagh.fedorapeople.org/packagereview/modular-release/modular-release.spec SRPM: https://sgallagh.fedorapeople.org/packagereview/modular-release/fedora-modular-release-26-0.5.fc26.src.rpm (In reply to Neal Gompa from comment #12) > Oh, and since this package is using Fedora trademarks, it must be licensed > in the same manner that "fedora-release" is, with the same notices. I think it already is; did I miss something? (In reply to Neal Gompa from comment #13) > @Stephen: > > A couple of other nitpicks: > > * The ID should be "fedora-modular" rather than "fedoramodular". Likewise > for the CPE name. > * "ID_LIKE=fedora" should be added Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx