https://bugzilla.redhat.com/show_bug.cgi?id=1422555 Gianluca Sforna <giallu@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(giallu@xxxxxxxxx) | --- Comment #10 from Gianluca Sforna <giallu@xxxxxxxxx> --- (In reply to Randy Barlow from comment #9) > The package contains a subset of glibc in its gnu_regex folder. Apprently, that folder is used only on non POSIX systems (e.g. Windows) to provide the functions but otherwise are not used. For good measure, I am now removing the directory in the %prep section. > > [!]: Development files must be in a -devel package > > This is the one I mentioned upon my first review. You need to add an > arduino-ctags-devel package that has all the .h files, and installs them > into %{_includedir}/arduino-ctags/. However, you should not include the > glibc headers from the gnu_regex folder. I thought this was settled in my previous comment. I am not shipping any library here, just a single executable so no library to link against => no -devel needed. > I recommend adding comments over your Patch0 and Patch1 lines that give a > brief description of the patch, especially the CVE patch. It's a little > surprising that the 5.8-11 release from November would not have a CVE from > 2014 fixed. Added a couple comments. Both patches are coming from the ctags Fedora package, but I added the CVE one just to avoid bug reports later. As a matter of fact, it affected JavaScript parsing, so it was not really relevant for this package. Spec URL: https://giallu.fedorapeople.org/arduino-ctags.spec SRPM URL: https://giallu.fedorapeople.org/arduino-ctags-5.8-4.arduino11.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx