[Bug 1428974] Review Request: rgbds - Game Boy development package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428974

Miro Hrončok <mhroncok@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dlabsky@xxxxxxxxxx
              Flags|                            |needinfo?(dlabsky@xxxxxxxxx
                   |                            |m)



--- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
The License tag says: DWPL and ISC and MIT

>From reading the LICENSE [0], I'd say it shall be: DWPL and ISC and MIT and BSD

Adding an explanation comment (Such as "See LICENSE for details") would be
nice.

I'd suggest you remove the commented out "#Requires:       ".

Also, the Q=(nothing) in %build is confusing, maybe change it to Q=""?

Why is the debuginfo package disabled?

[0]: https://github.com/rednex/rgbds/blob/v0.2.4/LICENSE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]