[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428562

Jan Chaloupka <jchaloup@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |decathorpe@xxxxxxxxx,
                   |                            |jchaloup@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |jchaloup@xxxxxxxxxx
              Flags|                            |fedora-review+
                   |                            |needinfo?(decathorpe@gmail.
                   |                            |com)



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
I guess you can remove:
Provides:       golang(%{import_path}/example) = %{version}-%{release}
%gotest %{import_path}/example

Plus upgrade the installation scripts to skip the example directory.

The package is an example. Nothing that makes sense to import in other
projects. Unless proven otherwise.

Otherwise LGTM. Again, the nit is not a blocker.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]