https://bugzilla.redhat.com/show_bug.cgi?id=1428820 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 is usable. Ok. Source archive (SHA-256: 91d608e8e50ab23fbe0208f29e90ae69487f1cb3069a736a4ea7ef56f6acc4f4) is original. Ok. Summary verified from lib/Task/Kensho/WebCrawling.pm. Ok. Description verified from lib/Task/Kensho/WebCrawling.pm. Ok. License verified from LICENSE, lib/Task/Kensho/WebCrawling.pm. No XS code, noarch BuildArch is Ok. TODO: Remove an epoch from `perl(:VERSION)' dependency version. Module::Build::Tiny, CPAN::Meta and CPAN::Meta::Prereqs are not helpful. Ok. TODO: Pass PERL_MM_FALLBACK_SILENCE_WARNING=1 environment variable to Makefile.PL to skip useless delay. All tests pass. Ok. $ rpmlint perl-Task-Kensho-WebCrawling.spec ../SRPMS/perl-Task-Kensho-WebCrawling-0.39-1.fc27.src.rpm ../RPMS/noarch/perl-Task-Kensho-WebCrawling-0.39-1.fc27.noarch.rpm perl-Task-Kensho-WebCrawling.src: W: spelling-error %description -l en_US amongst -> among st, among-st, among perl-Task-Kensho-WebCrawling.noarch: W: spelling-error %description -l en_US amongst -> among st, among-st, among 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-WebCrawling-0.39-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Mar 3 13:48 /usr/share/doc/perl-Task-Kensho-WebCrawling -rw-r--r-- 1 root root 6785 May 14 2016 /usr/share/doc/perl-Task-Kensho-WebCrawling/Changes -rw-r--r-- 1 root root 1618 May 14 2016 /usr/share/doc/perl-Task-Kensho-WebCrawling/README drwxr-xr-x 2 root root 0 Mar 3 13:48 /usr/share/licenses/perl-Task-Kensho-WebCrawling -rw-r--r-- 1 root root 18352 May 14 2016 /usr/share/licenses/perl-Task-Kensho-WebCrawling/LICENSE -rw-r--r-- 1 root root 3097 Mar 3 13:48 /usr/share/man/man3/Task::Kensho::WebCrawling.3pm.gz drwxr-xr-x 2 root root 0 Mar 3 13:48 /usr/share/perl5/vendor_perl/Task drwxr-xr-x 2 root root 0 Mar 3 13:48 /usr/share/perl5/vendor_perl/Task/Kensho -rw-r--r-- 1 root root 4407 May 14 2016 /usr/share/perl5/vendor_perl/Task/Kensho/WebCrawling.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-WebCrawling-0.39-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(HTTP::Thin) 1 perl(HTTP::Tiny) 1 perl(LWP::Simple) 1 perl(LWP::UserAgent) 1 perl(strict) 1 perl(warnings) 1 perl(WWW::Mechanize) 1 perl(WWW::Mechanize::TreeBuilder) 1 perl(WWW::Selenium) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-WebCrawling-0.39-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Task::Kensho::WebCrawling) = 0.39 1 perl-Task-Kensho-WebCrawling = 0.39-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Task-Kensho-WebCrawling-0.39-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=18156355). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx