[Bug 1428437] Review Request: golang-github-bkaradzic-go-lz4 - Port of LZ4 lossless compression algorithm to Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1428437

Jan Chaloupka <jchaloup@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jchaloup@xxxxxxxxxx,
                   |                            |tcallawa@xxxxxxxxxx
              Flags|                            |fedora-review?
                   |                            |needinfo?(tcallawa@redhat.c
                   |                            |om)



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Just a nit. I would suggest to move
%{gopath}/src/%{import_path}/testdata
line form %files unit-test-devel into %install section as
echo "%%{gopath}/src/%%{import_path}/testdata" >> unit-test-devel.file-list
right under
cp -pvr testdata %{buildroot}/%{gopath}/src/%{import_path}/

So the directory ownership is as close to the command it created it as
possible.

Wrt. book copyrights, Tom, can you take a look at it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]