https://bugzilla.redhat.com/show_bug.cgi?id=1428691 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: 94e572ffdad457452c0ae8f33c10120c044deb711091c27b2077dc3b19a8b67e) is original. Ok. Summary verified from lib/Email/Stuffer.pm. Ok. TODO: I found the "Email:: emails" quite confusing. Simply removing the "Email::" word makes the summary better. Description verified from lib/Email/Stuffer.pm. Ok. License verified from lib/Email/Stuffer.pm, LICENSE, README. Ok. No XS code, noarch BuildArch is Ok. CPAN::Meta and CPAN::Meta::Prereqs are not helpful. Ok All tests pass. Ok. $ rpmlint perl-Email-Stuffer.spec ../SRPMS/perl-Email-Stuffer-0.014-1.fc27.src.rpm ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm drwxr-xr-x 2 root root 0 Mar 3 08:59 /usr/share/doc/perl-Email-Stuffer -rw-r--r-- 1 root root 2315 May 1 2016 /usr/share/doc/perl-Email-Stuffer/Changes -rw-r--r-- 1 root root 418 May 1 2016 /usr/share/doc/perl-Email-Stuffer/README drwxr-xr-x 2 root root 0 Mar 3 08:59 /usr/share/licenses/perl-Email-Stuffer -rw-r--r-- 1 root root 18406 May 1 2016 /usr/share/licenses/perl-Email-Stuffer/LICENSE -rw-r--r-- 1 root root 5350 Mar 3 08:59 /usr/share/man/man3/Email::Stuffer.3pm.gz drwxr-xr-x 2 root root 0 Mar 3 08:59 /usr/share/perl5/vendor_perl/Email -rw-r--r-- 1 root root 28456 May 1 2016 /usr/share/perl5/vendor_perl/Email/Stuffer.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(:VERSION) >= 5.5.0 1 perl(Carp) 1 perl(Email::MIME) >= 1.920 1 perl(Email::MIME::Creator) 1 perl(Email::Sender::Simple) 1 perl(File::Basename) 1 perl(Module::Runtime) 1 perl(Params::Util) >= 1.05 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm | sort -f | uniq -c 1 perl(Email::Stuffer) = 0.014 1 perl-Email-Stuffer = 0.014-1.fc27 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Email-Stuffer-0.014-1.fc27.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F27 (https://koji.fedoraproject.org/koji/taskinfo?taskID=18150839). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx