https://bugzilla.redhat.com/show_bug.cgi?id=1366997 Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kryzhev@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |kryzhev@xxxxxxxx --- Comment #1 from Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> --- The are some minor issues I could see. 1. Group tag is not required. 2. You should add "Provides: critcl" 3. man files are auto-gzipped during run, do not do it manually. 4. defattr is obsoleted. 5. license.terms file must go under %license macro. 6. I believe there is a misprint in license.terms: "other parties" should be "and other parties". And I'm not sure whether zlib sources could be supplied in examples. I suppose "yes" (and mark it somewhere near License tag in spec) but if you know other example that's would be great. Not so minor. 1. As I can see it is a fully noarch package. So all extensions must go to %{_datadir}/tcl%{tcl_version} but not %{_libdir}/tcl%{tcl_version} and "BuildArch: noarch" must be added. 2. critcl_c subdir contain parts of tcl and tk of different versions and part of X11. Is it really necessary? You should consider to use system ones or get the permission. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx