Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alpine - UW Alpine mail user agent https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249365 ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-07-23 20:23 EST ------- Quick glance over the spec: - Ditch the vendor and packager tags; fedora build system will fill in the correct values. See Packaging/Guidelines#tags for details - Is the Conflict tag really needed? couldn't it be replaced with a proper versioned Obsoletes? - Are you sure that the Description tag needs the second and third paragraph? For most users, those pieces of info will tell nothing - Ditch the '[ "$RPM_BUILD_ROOT" != "/" ] &&' part from %clean and %install. It is no longer needed for ages. - It would be wiser to use the 4 arguments form of %defattr - I have to recheck that, but I think Applications/Mail does not seem to be a standard group - Apache 2.0 does not seem to be the proper value for the license tag (according to http://www.opensource.org/licenses/apache2.0.php I guess it should be "Apache License, Version 2.0") - last but not least, mock build fails with: checking for make... /usr/bin/make checking for setupterm in -ltinfo... no checking for setupterm in -lncurses... no checking for tgetent in -ltermlib... no checking for tgetent in -ltermcap... no configure: error: Terminfo/termcap not found error: Bad exit status from /var/tmp/rpm-tmp.76610 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.76610 (%build) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review