[Bug 1425815] Review Request: radare2 - Reverse engineering framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1425815

Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kryzhev@xxxxxxxx



--- Comment #1 from Dmitrij S. Kryzhevich <kryzhev@xxxxxxxx> ---
Well.
There are too many bundled libs here. Parts of grub, zlib, squashfs, etc. Some
of them I believe could be substituted by system ones. Others... hm. You should
consider to request explicit permission for bundling exclusion in fed-releng.

I'm not sure whether rar-archive support is allowed at all in Fedora. You need
explicit permission from fed-legal I suppose. Rpmfusion maybe?

About spec.
1. Group tag is not required.
2. openssl and gmp support are disabled. Is it OK? If you will enable them add
their -devel parts to radare2 one Require.
3. To copy .a to libdir and... exclude it? Why?
4. make %{?_smp_mflags} LIBDIR=%{_libdir} PREFIX=%{_prefix} DATADIR=%{DATADIR}
HAVE_LIBVERSION=1
What is %{DATADIR} here? %{_datadir} ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux