https://bugzilla.redhat.com/show_bug.cgi?id=1403417 --- Comment #20 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- Some initial comments that would be good to address before I run fedora-review. 1/ Release: 0%{?dist} I suggest starting with release tag 1 instead of 0. https://fedoraproject.org/wiki/Packaging:Versioning 2/ please provide "justification" for adding a patch. This would help anyone looking at the spec file understand the purpose of the patch 3/ Some comments about macros - You have used %configure --disable-oss --enable-gtk-doc --enable-gtk-doc-html %make_build CFLAGS="%{optflags}" BINDIR=%{_bindir} %make_build ags-docs In this case, since you have already used %configure macro, CFLAGS and BINDIR options for %make_build are superfluous. If you run, rpm -E %configure you will notice that compiler flags and bindir are already set. 3/ from the %files section %{_bindir}/* %{_mandir}/man1/* This is a no-no. This package simply cannot own all packages under /usr/bin and /usr/share/man. 4/ Similarly, %files -n gsequencer-devel-doc %{_datadir}/gtk-doc/ I suggest making the directories owned more explicit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx