[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1219662

Tim Orling <TicoTimo@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #18 from Tim Orling <TicoTimo@xxxxxxxxx> ---
In Comment 17, I believe you meant "Do NOT build for python2 on EPEL", which is
what it says in the ChangeLog (python2-tornado package is too old on EPEL).

[x] Latest version is packaged
[x] nosetests -v (tests run verbosely)

Builds and all tests pass on F26 Rawhide and EPEL7 (Bonus, thank you!).

All review comments have been properly addressed. I am not including the result
of fedora-review since it is not significantly different than the first review
(except for the above two resolved issues).

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]