[Bug 1426994] Review Request: rhythmbox-alternative-toolbar - Rhythmbox plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1426994



--- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hi tonet,

fedora-review was complaining about not running glib-compile-schemas in postun,
but that's not needed as we can see in [1].

There is no need to use a commit in the Source0, since upstream provides tags.
See [2] for reference.

The following directories are being created but not owned:
  /usr/share/rhythmbox/plugins/alternative-toolbar/ui
  /usr/share/rhythmbox/plugins/alternative-toolbar
  /usr/share/rhythmbox/plugins/alternative-toolbar/img
Your package should own these.

Your LICENSE file seems to be duplicated, as you can see here:
  /usr/lib64/rhythmbox/plugins/alternative-toolbar/LICENSE
  /usr/share/licenses/rhythmbox-alternative-toolbar/LICENSE

The rhythmbox package excludes some architectures (s390 s390x), shouldn't you
do the same, since this is a plugin for it?

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1409315
[2]
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]