https://bugzilla.redhat.com/show_bug.cgi?id=1415331 --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Raphael Groner from comment #4) > Thanks for the reminder and sorry for my delayed response. No problem. Thank you for the very thorough review. > Issues: > ======= > - Dist tag is present. It's mandatory to append %{?dist} to Release. > https://fedoraproject.org/wiki/Packaging:DistTag Fixed. > [?]: Package functions as described. > => I don't know how to test. There are tests available at upstream, but > also unkwon how to execute them, especially maybe in %check? I added a %check section. I had a long WTF?!!! moment, because I didn't know that .gitattributes can be used to silently skip file from the archive. I couldn't find a way to undo this, short of cloning the repo, removing the .gitattributes file, and commiting! (yes, git archive takes the .gitattributes from HEAD, not from working directory). One of the tests was failing, I filed an issue upstream, linked from the spec file. This package will also be tested by diffoscope: it has a pretty extensive test suite. Once it's built, I'll make it a build dependency of diffoscope. Note: there's an rpmlint warning about macro in comment. That's from %{version} in the tarball rebuild instructions. I'm keeping it that way so it's possible to run rpmspec -P and copy&paste the instructions into a shell. > [!]: Packages should try to preserve timestamps of original installed > files. > => cp -ap enjarify %buildroot%python3_sitelib/ Fixed. Spec URL: http://in.waw.pl/~zbyszek/fedora/enjarify.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/enjarify-1.0.3-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx