https://bugzilla.redhat.com/show_bug.cgi?id=1410594 --- Comment #6 from greg.hellings@xxxxxxxxx --- (In reply to Matthias Runge from comment #5) > additional nits: > - you missed a changelog entry for 0.24 Oops! Added that back in > - please rename python2-beaker-common and python2-beaker-client to avoid > clashes with python-beaker (the other package) Do you have a suggestion on naming? "beaker-client" and "beaker-common" are what the packages are called in pip, and this avoids a naming interference with the other project also called "beaker". Thus, "beaker-client" is the name people will be expecting to find if they are searching for the package. I'm not sure we'll ever see a naming collision with the other beaker project, as the other one doesn't divide into subpackages. > - you shouldn't need to require python itself. I've removed this. > - this bundles jquery-2, please remove > /Server/bkr/server/static/javascript/jquery-2.0.2.min.js and replace it with > requires: js-jquery (and add a link, whatever) > - please add info about bundled libraries, see > https://fedoraproject.org/wiki/Packaging: > Guidelines#Bundling_and_Duplication_of_system_libraries > - please look into upgrading jquery-ui, and add bundles for it > https://www.cvedetails.com/cve/CVE-2010-5312/ > > are you planning to add subpackages for server, lab-controller and > integration tests? I already remove the entire Server directory before build beacause it has a LARGE number of bundled dependencies it depends on (jQuery/jQuery-ui are included in the source, and there's around a dozen other source tarballs from other github projects that need to be included for those subpackages to build). I have no intention of packaging Server as I do not intend to package all of those dependencies also. The upstream project releases full RPM builds for the server and lab controller systems which are of specialized interest to server room maintainers. I plan to leave that completely in their purview rather than trying to bundle all of those subpackages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx