[Bug 1410953] Review Request: python3-cffi.spec - Foreign Function Interface for Python to call C code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1410953

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
I'd change (also in the Fedora pakage): add -v to tests so that names not dots
are shown.

Compared to the Fedora package:

+ package name is OK
+ builds and install OK
+ P/R/BuildRequires look correct
+ rpmlint is happy

Package is APPROVED.

(rpmlint:
python34-cffi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.4/site-packages/cffi/parse_c_type.h
python34-cffi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.4/site-packages/cffi/_cffi_include.h
python34-cffi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.4/site-packages/cffi/_embedding.h
+ some false positives

This is OK.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]