[Bug 1422555] Review Request: arduino-ctags - A mix of ctags and anjuta-tags for the perfect C++ ctags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1422555

Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giallu@xxxxxxxxx
              Flags|                            |needinfo?(giallu@xxxxxxxxx)



--- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> ---
There are a few things we must fix before this package can be approved:

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/arduino/tools-
     builder/ctags/5.8arduino11, /usr/share/arduino, /usr/share/arduino
     /tools-builder/ctags, /usr/share/arduino/tools-builder

     Does it make sense for this package to own tools-builder? If
     not, should we request that arduino-core provide it?


[!]: Development files must be in a -devel package

     You should put the header files into a devel package.


[!]: Package obeys FHS, except libexecdir and /usr/target.

     The shared lib is arch-dependent, and so should go into
     %{_libdir}. Is make install not suffiencent for this package?


One optional suggestion from rpmlint:

arduino-ctags.x86_64: E: incorrect-fsf-address
/usr/share/licenses/arduino-ctags/COPYING

You could work with upstream to correct the fsf address in the COPYING file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]