[Bug 1424851] Review Request: xplayer-plparser - Xplayer playlist parser

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1424851



--- Comment #2 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> ---
(In reply to leigh scott from comment #1)
> .typelib should be moved from -devel to main
> 
> /usr/lib64/girepository-1.0/XplayerPlParser-1.0.typelib
> 
> 
> .gir should be moved from main to -devel
> 
> /usr/share/gir-1.0/XplayerPlParser-1.0.gir

Fixed in updated package.


> These can be removed as gnome-common requires them
> 
> BuildRequires:	autoconf
> BuildRequires:	automake
> BuildRequires:	gettext

Explicit BRs don't hurt, I think…


> Please change this from
> 
> NOCONFIGURE=1 %{_bindir}/gnome-autogen.sh
> 
> 
> to (the commands aren't equal and miss a required macro).
> 
> NOCONFIGURE=1 ./autogen.sh

Well, it doesn't change the result of the build.  Using ./autogen.sh is just
needed for out-of-tree builds…

***

Updated package:

Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/xplayer-plparser-1.0.2-0.2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]