[Bug 1421245] Review Request: libcrush - C library to control placement in a hierarchy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421245



--- Comment #8 from Loic Dachary <loic@xxxxxxxxxxx> ---
> SRPM URL -> 404 not found

Will add updated URLs to the next comment.

> %define libname %{name}1

Removed and package renamed from libcrush1 to libcrush

> Requires:       %{libname} = %{version}

Chanted to
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

Requires:       %{name}%{?_isa} = %{version}-%{release}

> Descriptions of both packages are the same.

Updated the devel packages description:

%description devel
This package contains libraries and headers needed to develop programs
that use the libcrush library.

> # FIXME: you should use %%cmake macros

Changed to:

%cmake .

> Is relinking with libm necessary?

Yes.

> Wrong installation directory for arch-specific .pc files.
> Wrong libdir definition for 64-bit targets.

Both changed to use %{_libexecdir} 
https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir

> Adding /usr/include/crush to headers search path bears risk, since that directory includes headers with very generic names.

Using pkgconfig --cflags is not mandatory, it is a convenience.

> %changelog

Added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]