https://bugzilla.redhat.com/show_bug.cgi?id=1420100 --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed $ rpm -qp --requires perl-Mail-Transport-3.000-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Carp) 1 perl(Errno) 1 perl(File::Spec) 1 perl(Mail::Reporter) 1 perl(Mail::Transport) 1 perl(Mail::Transport::Send) 1 perl(Net::SMTP) 1 perl(base) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add run-requires - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75 $ rpm -qp --provides perl-Mail-Transport-3.000-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Mail::Transport) = 3.000 1 perl(Mail::Transport::Exim) = 3.000 1 perl(Mail::Transport::Mailx) = 3.000 1 perl(Mail::Transport::Qmail) = 3.000 1 perl(Mail::Transport::Receive) = 3.000 1 perl(Mail::Transport::SMTP) = 3.000 1 perl(Mail::Transport::Send) = 3.000 1 perl(Mail::Transport::Sendmail) = 3.000 1 perl-Mail-Transport = 3.000-1.fc26 Binary provides are Ok. $ rpmlint ./perl-Mail-Transport* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok BuildRequires FIX: Please add following build-requires: - coreutils - because 'rm' is used in spec file - findutils - 'find' is used in spec file - make - is used in spec file - perl or %{__perl} - it is used in spec file - perl(base) - Mail-Transport-3.000/lib/Mail/Transport.pm:12 - perl(IO::Handle) - Mail-Transport-3.000/Makefile.PL:5 - perl(IO::Lines) - Mail-Transport-3.000/lib/Mail/Transport/SMTP.pm:75 - perl(strict) - modules and tests - perl(Test::More) - tests - perl(vars) - modules - perl(warnings) - modules and tests FIX: Please remove __requires_exclude of Mail::SpamAssassin, it is not needed. TODO: It will be better placed %{?perl_default_filter} before %description. If you want to add the package to EPEL, please ignore these two TODO TODO: The easier way to remove .packlist is used NO_PACKLIST option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. It can be used in all Fedoras. The command is %{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 TODO: Remove the deleting empty directories in %install section. This is default behavior for Fedoras. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx