[Bug 1305718] Review Request: nodejs-preserve - Substitute tokens in the given `string` , then put them back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1305718

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
approved but you do have some deprecated lines in your specfile, you might need
to update your template.


>> %{?nodejs_find_provides_and_requires}
This macro should be in all active Fedora and epel releases now and is not
needed anymore.

>> %{nodejs_arches}
Same as above, you can remove the conditionals now.

>> %setup and %patch
Should be done with %autosetup

>> %license
is in all Active releases, no need for:
%{!?_licensedir:%global license %doc}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]