[Bug 1420329] Review Request: python-django-cors-headers - A Django application for handling the CORS headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1420329



--- Comment #4 from Dan Callaghan <dcallagh@xxxxxxxxxx> ---
Looks like you are missing

%license LICENSE.txt

in both subpackages, maybe consider also

%doc README.rst HISTORY.rst

Also note that EPEL7 has a functional Python 3 stack, you could consider
changing the conditionals to enable Python 3 subpackage on EPEL7.

rpmlint has some complaints about the Summary:

python2-django-cors-headers.noarch: W: summary-not-capitalized C
django-cors-headers is a Django application for handling the server headers
required for Cross-Origin Resource Sharing (CORS).
python2-django-cors-headers.noarch: W: summary-ended-with-dot C
django-cors-headers is a Django application for handling the server headers
required for Cross-Origin Resource Sharing (CORS).
python2-django-cors-headers.noarch: E: summary-too-long C django-cors-headers
is a Django application for handling the server headers required for
Cross-Origin Resource Sharing (CORS).

How about this instead:

Summary: Django application for handling Cross-Origin Resource Sharing (CORS)
headers

Everything else looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]