https://bugzilla.redhat.com/show_bug.cgi?id=1411984 Nemanja Milosevic <nmilosev@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nmilosev@xxxxxxxxxxxxxxxxx --- Comment #13 from Nemanja Milosevic <nmilosev@xxxxxxxxxxxxxxxxx> --- Informal review (new packager, bare with me): I also like this spec file, but I have to agree with Loic, the blank lines are making it uglier. One other suggestion: Currently you have this: URL: https://github.com/dylanaraps/%{name}/tree/%{version} Source0: https://github.com/dylanaraps/%{name}/archive/%{version}.tar.gz I'm unsure if URL should be version independent. If it should be you could fix this up a bit like so: URL: https://github.com/dylanaraps/%{name} Source0: %{url}/archive/%{version}.tar.gz Just a suggestion, great work otherwise. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx