https://bugzilla.redhat.com/show_bug.cgi?id=1422697 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: + Package is named correctly + Package has license noted correctly and license file is installed + Subpackages are set up according to Python packaging guidelines + No issues from rpmlint or fedora-review + %check section has tests run that pass ! Unnecessary "rm -rf %{buildroot}" in %install (this isn't targeting EL5...) It looks good to me. Drop the unnecessary command in %install mentioned above and the stray comment on import. A suggestion: Tighten the "Requires: python2-resultsdb_conventions" to "Requires: python2-resultsdb_conventions = %{version}-%{release}" so that they upgrade together in lockstep. You don't have to, but I think it'd probably be a good idea. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx