[Bug 1422689] Review Request: python-openqa_client - Python client library for openQA API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1422689

Neal Gompa <ngompa13@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Review notes:

+ Package is named correctly
+ Package has license noted correctly and license file is installed in all
subpackages
+ Subpackages are set up according to Python packaging guidelines
+ No issues from rpmlint or fedora-review
- Empty %check section (at least you know, so not dinging you about it!)
! Unnecessary "rm -rf %{buildroot}" in %install (this isn't targeting EL5...)

It looks good to me. Just drop the unnecessary command in %install mentioned
above on import.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]