https://bugzilla.redhat.com/show_bug.cgi?id=1413978 James Hogarth <james.hogarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from James Hogarth <james.hogarth@xxxxxxxxx> --- ===== Issues ===== * defattr in %files - since el5 is dropped this should be removed * Buildroot present - since el5 is dropped this should be removed * package functions as described - assuming this is good as tests pass ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 191 files have unknown license. Detailed output of licensecheck in /home/james/workspace/fedora-scm/1413978-php-sabre- vobject4/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: php-sabre-vobject4 (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 5.0.4 DB version 1.17.0 built Jan 24 2017 10:56:54 CET static analyze results in /home/james/workspace/fedora- scm/1413978-php-sabre-vobject4/phpci.log Rpmlint ------- Checking: php-sabre-vobject4-4.1.2-1.fc26.noarch.rpm php-sabre-vobject4-4.1.2-1.fc26.src.rpm php-sabre-vobject4.noarch: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.noarch: W: spelling-error Summary(en_US) vCard -> v Card, card php-sabre-vobject4.noarch: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.noarch: W: spelling-error %description -l en_US vCard -> v Card, card php-sabre-vobject4.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities php-sabre-vobject4.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-vobject4.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-sabre-vobject4.noarch: E: wrong-script-interpreter /usr/bin/generate_vcards /usr/bin/env php php-sabre-vobject4.noarch: E: wrong-script-interpreter /usr/bin/vobject /usr/bin/env php php-sabre-vobject4.noarch: W: no-manual-page-for-binary vobject php-sabre-vobject4.noarch: W: no-manual-page-for-binary generate_vcards php-sabre-vobject4.src: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.src: W: spelling-error Summary(en_US) vCard -> v Card, card php-sabre-vobject4.src: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.src: W: spelling-error %description -l en_US vCard -> v Card, card php-sabre-vobject4.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities php-sabre-vobject4.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-vobject4.src: W: spelling-error %description -l en_US usr -> use, us, user php-sabre-vobject4.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 2 packages and 0 specfiles checked; 2 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory php-sabre-vobject4.noarch: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.noarch: W: spelling-error Summary(en_US) vCard -> v Card, card php-sabre-vobject4.noarch: W: spelling-error %description -l en_US iCalendar -> i Calendar, calendar, legendarily php-sabre-vobject4.noarch: W: spelling-error %description -l en_US vCard -> v Card, card php-sabre-vobject4.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities php-sabre-vobject4.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-vobject4.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-sabre-vobject4.noarch: E: wrong-script-interpreter /usr/bin/generate_vcards /usr/bin/env php php-sabre-vobject4.noarch: E: wrong-script-interpreter /usr/bin/vobject /usr/bin/env php php-sabre-vobject4.noarch: W: no-manual-page-for-binary generate_vcards php-sabre-vobject4.noarch: W: no-manual-page-for-binary vobject 1 packages and 0 specfiles checked; 2 errors, 9 warnings. Requires -------- php-sabre-vobject4 (rpmlib, GLIBC filtered): /usr/bin/env php(language) php-cli php-composer(fedora/autoloader) php-composer(sabre/xml) php-date php-json php-mbstring php-pcre php-spl php-xml Provides -------- php-sabre-vobject4: php-composer(sabre/vobject) php-sabre-vobject4 Source checksums ---------------- https://github.com/fruux/sabre-vobject/archive/d0fde2fafa2a3dad1f559c2d1c2591d4fd75ae3c/php-sabre-vobject4-4.1.2-d0fde2f.tar.gz : CHECKSUM(SHA256) this package : fd12058b77506186763655a095344b8ded3bc4e7273c4b1fa640b5189764ae22 CHECKSUM(SHA256) upstream package : fd12058b77506186763655a095344b8ded3bc4e7273c4b1fa640b5189764ae22 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1413978 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ===== Result ===== Package is APPROVED but please remove Buildroot and defattr during import -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx