[Bug 1421858] Review Request: flannel-container - system container for flannel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421858



--- Comment #1 from Tomas Tomecek <ttomecek@xxxxxxxxxx> ---
https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L1
> FROM fedora

Please pin to a specific fedora version, as described in guidelines.

https://fedoraproject.org/wiki/Container:Guidelines#CMD_.2F_ENTRYPOINT


https://github.com/projectatomic/atomic-system-containers/blob/master/flannel/Dockerfile#L5
> ENV container=docker
> ENV FLANNELD_ETCD_ENDPOINTS="http://127.0.0.1:2379";
> ...

Chain these, so they are within a single instruction. LABEL on line 10 does it
right.


It would also be great to have some documentation inside container how should
one use it.


Anyway, well done. I haven't found any serious issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]