[Bug 1421245] Review Request: libcrush - C library to control placement in a hierarchy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421245



--- Comment #3 from Loic Dachary <loic@xxxxxxxxxxx> ---
Thanks for your review !

> According to the Fedora package documentation, the BuildRoot should be left untouched [2].

Removed.

> The group tag is deprecated [2].

Removed.

> The release tag should be like '1%{?dist}' [2].

Changed.

> Another remark, the use of %defattr is no longer necessary unless the permissions need to be altered [3].

Removed.

I'll try to contribute to your own package. Although you know more than I do
and maybe there is nothing for me to criticize ;-)

Cheers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]