https://bugzilla.redhat.com/show_bug.cgi?id=1421603 --- Comment #2 from Honza Horak <hhorak@xxxxxxxxxx> --- Thanks for the suggestions! (In reply to Tomas Tomecek from comment #1) > > io.k8s.display-name="Fedora alternative to Developer Toolset Toolchain" > > I would name it as "Fedora variant of software collection Devel..." Hm, what about "Fedora variant of Developer Toolset's Toolchain from Software Collections" > > ADD contrib/bin/usage /usr/local/bin/usage > > Why don't you add it to /opt/app-root? (nitpick) Reported in https://github.com/sclorg/devtoolset-container/issues/15, but will fix in the Fedora one. > I would also prefer COPY (since ADD may have side effects). Ack. > > https://hhorak.fedorapeople.org/toolchain-docker/contrib/etc/scl_enable > > This seems redundant. Yes, this is not relevant in Fedora. > I would also like to see some documentation with better examples: how would > I use the container to compile my code? Good question, we should have it written better in the usage and provide some nice README.md, which is now missing entirely. Will work on it with Marek (original author of https://github.com/sclorg/devtoolset-container/tree/master/4-toolchain) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx