https://bugzilla.redhat.com/show_bug.cgi?id=1409355 --- Comment #4 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to Mamoru TASAKA from comment #3) > > > > 1) Occasionally there is a cryptic error message: > > > > invalid command name ".w00010.msg" > > > > This message occurs also on F25 (with both: ruby-tcltk package, or > > recompiled rubygem-tk), so this is already existing problem (not a > > show-stopper for upgrade from ruby-tcltk). > > Currently I don't see this issue (yet?) > I have Fedora 25, and it happens only occasionally, with dialog1.rb and dialog2.rb. (tested both demo-en and demo-jp, with or without locales) > > > 2) When closing the demo window, ruby crashes. > > > > Ruby won't crash in F25, so this is a new problem with F26. > > > > I'm not sure, what to do with the second problem. Continue with packaging > > and report upstream? It is possible it is only bug in the demo code? (there > > are used threads, ...). > > Will try on F-26, however currently I think this is ruby issue (perhaps), > may be bug 1417590 : GC issue with gcc7, hopefully fixed in > ruby-2.4.0-76.fc26 > It's still happening with ruby-2.4.0-76.fc26. :-( It looks like some infinite loop after raise... Produced backtrace: http://scientific.zcu.cz/fedora/REVIEWS/rubygem-tk/backtrace.txt You can look at it as ruby specialist. I'm OK with this, if you say so (considering it as known issue, ...). I can also test other ruby/rubygem-tk packages in rawhide. > > > Now the packaging itself, the easier part: :-) > > > > 3) the modification of gem.build_complete > > > > Well, as you know this is just to suppress rpmlint error (if reviewer does > not like rpmlint error). If you are okay, I can just make gem.build.complete > unmodified (i.e. just empty). > Yes, that's OK. > > > 4) gcc dependency is not needed > Unfortunately now this is MUST :( > https://fedoraproject.org/wiki/Packaging: > C_and_C%2B%2B#BuildRequires_and_Requires > Oh, I see. OK. (and I should check my packages :-)) > > 5) it could be safer to replace '/usr/local' and '/usr/bin/env ruby' only in > > 'sample' subdirectory (just a hint to consider, checking everything is > > probably fine and desired?) > > Because rpmlint warns these :( (Well, anyway we don't support /usr/local so > I think this is okay) > OK. > > 6) missing the "Provides: ruby-tcltk" > > > > There is comment about it, so it is probably OK a there is reason for it > > (not full functionality provided by 'tk' gem?). I've noticed there is still > > a TCL part available - at least the variable Tk::TCL_VERSION. > > The reason for this is that while I think (believe) ruby-tcltk functionality > is fully provided by rubygem-tk, I am not sure at a moment. > > Let me know it if you think it is better to modify. Again sorry for long > delay... Both packages looks identical (although I only compared list of ruby files and symbols in native libraries and tested some demos). Frantisek -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx