https://bugzilla.redhat.com/show_bug.cgi?id=1419032 Kees de Jong <keesdejong+bugs@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |keesdejong+bugs@xxxxxxxxx --- Comment #2 from Kees de Jong <keesdejong+bugs@xxxxxxxxx> --- I'm trying to gain some reputation to get my own package sponsored, so I will give it a go ahead to review yours. If you want you could give my much simpler package a review in return [1], if you don't see any improvements, then please leave a comment that you approve the package. According to the Fedora package documentation, the BuildRoot should be left untouched [2]. Another remark, the use of %defattr is no longer necessary unless the permissions need to be altered [3]. The group tag is deprecated [2]. Please also note that %clean section is redundant [2], unless you also build for EPEL. If not then the %clean section with the 'rm -rf $RPM_BUILD_ROOT' could be left out. The 'rm -rf $RPM_BUILD_ROOT' in the %install could probably also be left out? [1] https://bugzilla.redhat.com/show_bug.cgi?id=1411984 [2] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview [3] https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_basics -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx