[Bug 1421166] Review Request: perl-Config-ZOMG - Catalyst::Plugin:: ConfigLoader-style layer over Config::Any

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1421166

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Config-ZOMG-1.000000-1.fc26.noarch.rpm | sort | uniq
-c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Clone)
      1 perl(Config::Any)
      1 perl(Config::ZOMG::Source::Loader)
      1 perl(Hash::Merge::Simple)
      1 perl(List::Util)
      1 perl(Moo)
      1 perl(Sub::Quote)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Config-ZOMG-1.000000-1.fc26.noarch.rpm | sort | uniq
-c
      1 perl(Config::ZOMG) = 1.000000
      1 perl(Config::ZOMG::Source::Loader) = 1.000000
      1 perl-Config-ZOMG = 1.000000-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Config-ZOMG*
perl-Config-ZOMG.noarch: W: spelling-error Summary(en_US) ConfigLoader ->
Configuration
perl-Config-ZOMG.noarch: W: spelling-error %description -l en_US ConfigLoader
-> Configuration
perl-Config-ZOMG.src: W: spelling-error Summary(en_US) ConfigLoader ->
Configuration
perl-Config-ZOMG.src: W: spelling-error %description -l en_US ConfigLoader ->
Configuration
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

BuildRequires are ok
TODO: perl(Config::General) is optional for tests (t/12-loader-file.t,
      t/16-loader-order.t). Please consider to add it to build-requires.
      Now, it is install as dependency for perl-Config-Any.

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]