[Bug 1419226] Review Request: prelude-correlator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419226



--- Comment #6 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> ---
Hello,

Here are the new files :
SPEC : https://fedorapeople.org/~totol/prelude-correlator.spec
SRPM : https://fedorapeople.org/~totol/prelude-correlator-3.1.0-1.fc26.src.rpm

(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> > Prelude-Correlator seems to have this functionnality but it dit it in the wrong way. I prefere not to activate it and wait for upstream.
> 
> With systemd's User= setting, running as non-root requires no special
> support from the application, often. This gives an excellent ratio of
> security gain vs. inconvenience.
> 
> That said, if you prefer to wait for upstream, that makes sense too.
> (Although they are more likely to implement it "portably", i.e. from
> scratch, and mess something up ;))

I understand but for example, if the root user change things in
/etc/prelude-correlator , prelude-correlator may stop working because it can
not access / remove / modify files. For now, I prefer let it in this way if it
is possible.

> 
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> > s/SystemD/systemd/
> Still there.
> 

I don't see it in your comment, sorry. Done

> >> Hm, why do the python subpackage require prelude-correlator.rpm?
> >> prelude-correlator includes a service file which will not work without
> >> python3-p-c, so it seems prelude-correlator.rpm should require
> >> python3-prelude-correlator. I'm pretty sure that 'dnf install
> >> prelude-correlator' should yield a working setup.
> > You are right, Done
> 
> I don't think that's good as is. I think the main package (%name.rpm) should
> have
> Requires: python3-%{name}
> 
> (Otherwise, if you do dnf install %{name}, systemctl start %{name}, this
> will crash on failed import).

I write it too quickly. It is now OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]