https://bugzilla.redhat.com/show_bug.cgi?id=1421406 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robled@xxxxxxxxxxxxxxxxxxxx | |m Flags| |needinfo?(robled@electronsw | |eatshop.com) --- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Here are things we must fix before this can be approved: * You can't use macros in the changelog because they will change over time. i.e., you have the %{version} in there, but the next time you make a release your changelog for this release will change. You should instead hardcode 0.6.0-1 there. * Your python2- and python3- subpackages do not Require tmux like they should. The Require line applies to a non-existing python-tmux subpackage. I suggest deleting that line and copying it into the two %package -n sections so they each Require tmux. These things are suggestions, and are at your option: * The quotes in your desc global are literally going into the RPM descriptions. They aren't needed, so I suggest dropping them. * Should the ' character be followed by an s after in "tmux' target…" in the description? * You have a misleading comment in your install section about doing the py2 install first due to scripts in /usr/bin - there are no scripts in /usr/bin. I suggest dropping this comment. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx