https://bugzilla.redhat.com/show_bug.cgi?id=1415634 Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpena@xxxxxxxxxx Flags| |needinfo?(jpena@xxxxxxxxxx) --- Comment #1 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> --- Some things we must fix: * The license listed as TODO. Seems like we should put "ASL 2.0" there, based on fedora-review's licensecheck.txt output. * There seems to be some bundled JavaScript in the docs package. I suggest symlinking those to the Fedora packaged versions (like jquery), or by declaring them as bundled with a Provides: bundled(js-package_name) for each of those files. Either of those solutions will be sufficient. Some suggestions that are optional: * It seems that the unit tests are being installed. This can be fixed by patching the setup.py to exclude the tests. Of course, I suggest sending such a patch upstream. Here's an example from the bodhi setup.py: https://github.com/fedora-infra/bodhi/blob/2.3.3/setup.py#L152-L153 Another way to do it would be to just rm them, but I think doing it upstream in the setup.py is friendlier. * You can preserve the timestamps on your cp commands if you use the -p flag. * You can ln -s your man page for all the Python version variants (so man murano-pkg-check-3 still works). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx