https://bugzilla.redhat.com/show_bug.cgi?id=1327979 --- Comment #11 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> --- (In reply to Miro Hrončok from comment #10) > I didn't have time to examine this closely, but a quick question: > > What's the benefit of having both python2 and python3 notebooks? > > Isn't it possible to just have the Python 3 version and install the Python 2 > kernel to use it inside? > > (I really don't know) This is true, but you could still use both base versions of the notebook and decide between py3 vs py2. Debian also has both versions: - https://packages.debian.org/de/sid/python3-notebook - https://packages.debian.org/de/sid/python-notebook > If the above is true but the notebook module is to be imported form other > packages, then keep the package split, but just include the executable in > the Python 3 subpackage. > > Guidelines: > > If the executables provide the same functionality independent of whether > they are run on top of Python 2 or Python 3, then only the Python 3 version > of the executable should be packaged. Transitioning from python2 to python3 > is left to individual package maintainers except for packages in Fedora's > critical path. For these, we want to port to python3 versions in the same > Fedora release if possible. I removed the executable from the python2-notebook. (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > Review update: > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > > Links in /bin/ should be updated similarly to python-jupyter-client. > > Links are still reversed. It should be like this: > mv %{buildroot}/%{_bindir}/jupyter-nbextension > %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_version} > ln -s jupyter-nbextension-%{python3_version} > %{buildroot}/%{_bindir}/jupyter-nbextension-%{python3_pkgversion} > mv %{buildroot}/%{_bindir}/jupyter-serverextension > %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_version} > ln -s jupyter-serverextension-%{python3_version} > %{buildroot}/%{_bindir}/jupyter-serverextension-%{python3_pkgversion} > mv %{buildroot}/%{_bindir}/jupyter-notebook > %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_version} > ln -s jupyter-notebook-%{python3_version} > %{buildroot}/%{_bindir}/jupyter-notebook-%{python3_pkgversion} Changed. > and similarly for the python2 version. Removed (see above). > > %license. Added > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file COPYING.md is not marked as %license > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > > > Suggestion to use "%global _docdir_fmt %{name}". Added > > %description should be word wrapped to 80 columns. > > And since the description is longer than two sentences, it's nice to define > > a %_description and then use '%description [subpackage ] %_description' to > > avoid repeating the text. > > Still valid. Changed > Can you post an updated spec file? It would be great to get this wrapped up > some time > before F26, leaving enough time for testing. Sorry for the delay... I would welcome (co-)maintainers as I find increasingly less time to work on this, but want to have ipython updated in Fedora... I would remove the -doc package altogether as it uses intersphinx during the build. %changelog - rename to python-notebook - only ship python3 executables - update to 4.4.1 Spec URL: https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-notebook.spec SRPM URL: https://tomspur.fedorapeople.org/review/python-jupyter-notebook/python-notebook-4.4.1-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx