[Bug 1419152] Review Request: rubygem-memfs - fake file system that can be used for tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419152



--- Comment #4 from Eduardo Mayorga <e@xxxxxxxxxxxxxxxx> ---
(In reply to Athos Ribeiro from comment #2)
> About the other issue, I believe this is a problem with a fedora-review
> regex (I will check it): The guidelines say we are not supposed to use
> Requires: ruby(release),
> but says nothing about BuildRequires.
> 
> Since guidelines say to explicitly list all build requirements and that the
> most important packaged rubygems, like rails [1] do BuildRequires:
> ruby(release), I believe I should keep that BuildRequires there and patch
> fedora-review.
> 
> Any thoughts?
> 
> [1]
> http://pkgs.fedoraproject.org/cgit/rpms/rubygem-rails.git/tree/rubygem-rails.
> spec?id=ed97cb3b6b775f6759ef604ce58e82d06903e8e4

Sorry, what I actually meant was adding
BR: ruby(release) 
BR: ruby)
was probably not needed because rubygems-devel would pull it anyway. Absolutely
not problem with that though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]