https://bugzilla.redhat.com/show_bug.cgi?id=1419034 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: 5caeaada66ab4afdfdae56c023e099880543a9a7c1f931f20a834d5881c15ecb) is original. Ok. Summary verified from lib/Sub/Infix.pm. Ok. Description verified from lib/Sub/Infix.pm. Ok. License verified from lib/Sub/Infix.pm, t/01basic.t, README, LICENSE, COPYRIGHT, CONTRIBUTING. Ok. No XS code, noarch BuildArch is Ok. TODO: Package CREDITS file as a documentation. FIX: Build-require `make' (perl-Sub-Infix.spec:39). TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.17' (Makefile.PL:2). Scalar::Util and B modules are optional. Ok. All tests pass. Ok. $ rpmlint perl-Sub-Infix.spec ../SRPMS/perl-Sub-Infix-0.004-1.fc26.src.rpm ../RPMS/noarch/perl-Sub-Infix-0.004-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Sub-Infix-0.004-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Feb 9 17:27 /usr/share/doc/perl-Sub-Infix -rw-r--r-- 1 root root 455 Jul 2 2014 /usr/share/doc/perl-Sub-Infix/Changes -rw-r--r-- 1 root root 2312 Jul 2 2014 /usr/share/doc/perl-Sub-Infix/README drwxr-xr-x 2 root root 0 Feb 9 17:27 /usr/share/licenses/perl-Sub-Infix -rw-r--r-- 1 root root 1184 Jul 2 2014 /usr/share/licenses/perl-Sub-Infix/COPYRIGHT -rw-r--r-- 1 root root 18349 Jul 2 2014 /usr/share/licenses/perl-Sub-Infix/LICENSE -rw-r--r-- 1 root root 2301 Feb 9 17:27 /usr/share/man/man3/Sub::Infix.3pm.gz drwxr-xr-x 2 root root 0 Feb 9 17:27 /usr/share/perl5/vendor_perl/Sub -rw-r--r-- 1 root root 4330 Jul 2 2014 /usr/share/perl5/vendor_perl/Sub/Infix.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Sub-Infix-0.004-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(:VERSION) >= 5.6.0 1 perl(Carp) 1 perl(Exporter) 1 perl(overload) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. TODO: Suggests dependency on `perl(Scalar::Util)' (lib/Sub/Infix.pm:28). $ rpm -q --provides -p ../RPMS/noarch/perl-Sub-Infix-0.004-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Sub::Infix) = 0.004 1 perl(Sub::Infix::PartialApplication) 1 perl-Sub-Infix = 0.004-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Sub-Infix-0.004-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17693101). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' item and consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx