[Bug 1419043] Review Request: perl-Sub-Exporter-Lexical - Export lexically-available subs with Sub:: Exporter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419043

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
> BuildRequires
> FIX: Please remove duplicity 'perl(strict)' in BR.
> FIX: Please change the version restriction for perl(ExtUtils::MakeMaker) to
>      6.76 or higher, because NO_PACKLIST option (spec file line 37) was
>      added in this version.
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.30
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(Lexical::Sub)
-BuildRequires:  perl(strict)
Ok.


> FIX: Do you want to distribute the file 'snippet.pl'? It was put into
>      /usr/share/perl5/vendor_perl/Sub/Exporter. The dependencies for the file
>      are not generated, because 'file' detects it as 'ASCII text' and
> rpm-build 
>      does not process it by perl-generators.
> 
$ rpm -qpl perl-Sub-Exporter-Lexical-0.092292-2.fc26.noarch.rpm 
/usr/share/doc/perl-Sub-Exporter-Lexical
/usr/share/doc/perl-Sub-Exporter-Lexical/Changes
/usr/share/doc/perl-Sub-Exporter-Lexical/README
/usr/share/licenses/perl-Sub-Exporter-Lexical
/usr/share/licenses/perl-Sub-Exporter-Lexical/LICENSE
/usr/share/man/man3/Sub::Exporter::Lexical.3pm.gz
/usr/share/perl5/vendor_perl/Sub
/usr/share/perl5/vendor_perl/Sub/Exporter
/usr/share/perl5/vendor_perl/Sub/Exporter/Lexical.pm

Ok. snippet.pl is not distributed. 

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]