https://bugzilla.redhat.com/show_bug.cgi?id=1420099 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal) Summary|Review Request: |Review Request: |perl-Mail-Message |perl-Mail-Message - MIME | |message handling --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- The standalone and the packaged spec file differ in white space only. I will use the standalone one for this review. URL and Source0 addresses are Ok. Source archive (SHA-256: 3a70553d4898e783c0ae8645d6bb3c8fa1ed66f997627685a72119b02dd0be1d) is Ok. Summary is Ok. Description is Ok. License verified from lib/Mail/Message.pod and other POD files. Ok. FIX: The t/203-mlfolder.mbox and t/204-sgfolder.mbox files contain e-mail messages whose license is not very likely "GPL or Artistic". Since Fedora does not modify them and I believe their authors are content with their redistribution (because they were sent to public mailing lists), I think their existence in Fedora source packages does not violate copyright law. But they still can be unacceptable for Fedora because Fedora requires a permission for modification. Please add a notice into the spec file about their existence and negotiate their license with the Mail-Message author and their permissibility with Fedora legal department. No XS code, noarch BuildArch is Ok. FIX: Build-require `perl' because you execute it the spec file on lines 32 and 55. FIX: Build-require `coreutils' (perl-Mail-Message.spec:55). FIX: Build-require `make' (perl-Mail-Message.spec:56). FIX: Build-require `findutils' (perl-Mail-Message.spec:60). FIX: Build-require `glibc-common' (perl-Mail-Message.spec:66). TODO: Constrain `perl(URI)' dependency with `>= 1.23' (META.json:47). FIX: Build-require `perl(IO::Handle)' (Makefile.PL:5). FIX: Build-require `perl(warnings)' (Makefile.PL:96). FIX: Build-require `perl(base)' (lib/Mail/Message.pm:12). FIX: Build-require `perl(Carp)' (lib/Mail/Message.pm:22). FIX: Build-require `perl(Cwd)' (lib/Mail/Message/Test.pm:17). FIX: Build-require `perl(Email::Simple)' (lib/Mail/Message/Convert/EmailSimple.pm:20). FIX: Build-require `perl(Encode::Alias)' (lib/Mail/Message/Body/Encode.pm:24). FIX: Build-require `perl(Exporter)' (lib/Mail/Message/Test.pm:11). FIX: Build-require `perl(File::Basename)' (lib/Mail/Message/Body.pm:20). FIX: Build-require `perl(File::Copy)' (lib/Mail/Message/Test.pm:13). FIX: Build-require `perl(File::Temp)' (lib/Mail/Message/Body/File.pm:18). FIX: Build-require `perl(HTML::FormatText)' (lib/Mail/Message/Convert/HtmlFormatPS.pm:17). FIX: Build-require `perl(HTML::TreeBuilder)' (lib/Mail/Message/Convert/HtmlFormatPS.pm:16). FIX: Build-require `perl(integer)' (lib/Mail/Box/FastScalar.pm:13). FIX: Build-require `perl(IO::File)' (lib/Mail/Box/Parser/Perl.pm:16). FIX: Build-require `perl(IO::Handle)' (lib/Mail/Message/Field.pm:17). FIX: Build-require `perl(IO::Lines)' (lib/Mail/Message/Body/Lines.pm:15). FIX: Build-require `perl(List::Util)' (lib/Mail/Box/Parser/Perl.pm:15). FIX: Build-require `perl(Mail::Header)' (lib/Mail/Message/Convert/EmailSimple.pm:15). FIX: Build-require `perl(Mail::Identity)' (lib/Mail/Message/Field/Address.pm:12). FIX: Build-require `perl(Mail::Internet)' (lib/Mail/Message/Convert/EmailSimple.pm:14). FIX: Build-require `perl(MIME::Parser)' (lib/Mail/Message/Convert/MimeEntity.pm:16). FIX: Build-require `perl(MIME::QuotedPrint)' (lib/Mail/Message/Field/Full.pm:16). FIX: Build-require `perl(overload)' (lib/Mail/Message/Body.pm:27). FIX: Build-require `perl(POSIX)' (lib/Mail/Message/Field/Date.pm:14). FIX: Build-require `perl(Storable)' (lib/Mail/Message/Field/Full.pm:17). FIX: Build-require `perl(strict)' (lib/Mail/Message.pm:5). FIX: Build-require `perl(Text::Autoformat)' (lib/Mail/Message/Convert/TextAutoformat.pm:15). FIX: Build-require `perl(User::Identity::Collection::Emails)' (lib/Mail/Message/Field/AddrGroup.pm:12). FIX: Build-require `perl(utf8)' (lib/Mail/Message/Field/Full.pm:14). FIX: Build-require `perl(vars)' (lib/Mail/Message.pm:9). FIX: Build-require `perl(Data::Dumper)' (t/314encode-charset.t:13). TODO: Build-require `perl(Email::Abstract)' (t/423msgconv-emabs.t:14). TODO: Build-require `perl(Email::Simple)' (t/422msgconv-emsimp.t:16). FIX: Run-require `perl(Mail::Transport::Send)' (lib/Mail/Message.pm:164). FIX: Tests fail for me: t/322bodyconv-htmlps.t .... Can't locate Font/Metrics/TimesRoman.pm in @INC (you may need to install the Font::Metrics::TimesRoman module) (@INC contains: /home/test/rpmbuild/BUILD/Mail-Message-3.000/blib/lib /home/test/rpmbuild/BUILD/Mail-Message-3.000/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at /usr/share/perl5/vendor_perl/HTML/FormatPS.pm line 219. # Looks like your test exited with 2 before it could output anything. t/322bodyconv-htmlps.t .... Dubious, test returned 2 (wstat 512, 0x200) Failed 5/5 subtests Please correct all `FIX' items, consider fixing `TODO' items and provide a new spec file. Resolution: Package NOT approved. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx